Skip to content

Retry API request on connection errors #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefan-as merged 2 commits into from
Oct 27, 2020
Merged

Retry API request on connection errors #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25e8c02
Retry API request on connection errors
stefan-as Oct 27, 2020
8bd7081
refactor deprecated exception
stefan-as Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/quayio/scanner/repository.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,15 @@ def api_call(uri)
response = RestClient.get(
"https://quay.io/api/v1/repository/#{org}/#{repo}#{uri}",
authorization: "Bearer #{quayio_token}",
accept: :json
accept: :json,
open_timeout: 15
)
return JSON.parse(response)
rescue RestClient::ExceptionWithResponse => e
raise e if e.http_code != 520 || attempt >= MAX_ATTEMPTS
rescue RestClient::Exception => e
raise e if attempt >= MAX_ATTEMPTS

# retry later, if we hit cdn rate limiting or on connection errors
raise e unless e.http_code == 520 || e.http_code.nil?
Comment on lines +37 to +38

@jonathanschlue-as jonathanschlue-as Oct 27, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Mappt "connection error" 1-zu-1 auf "http_code.nil?" oder führen hier eventuell sogar noch andere Fehlerfälle zu nem Retry?

@stefan-as stefan-as Oct 27, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http_code.nil? bedeutet, dass nix sinnvolles per HTTP zurück gekommen ist. Das würde ich hier gelten lassen als: da ist was schief gegangen, nochmal probieren.


sleep(rand(10))
end
Expand Down