Retry API request on connection errors - #7
Merged
Conversation
jonathanschlue-as
approved these changes
Oct 27, 2020
jonathanschlue-as
left a comment
jonathanschlue-as
left a comment
Contributor
There was a problem hiding this comment.
1 Frage im Code, approve schonmal! 👍
Comment on lines
+37
to
+38
| # retry later, if we hit cdn rate limiting or on connection errors | ||
| raise e unless e.http_code == 520 || e.http_code.nil? |
Contributor
There was a problem hiding this comment.
👍 Mappt "connection error" 1-zu-1 auf "http_code.nil?" oder führen hier eventuell sogar noch andere Fehlerfälle zu nem Retry?
Contributor
Author
There was a problem hiding this comment.
http_code.nil? bedeutet, dass nix sinnvolles per HTTP zurück gekommen ist. Das würde ich hier gelten lassen als: da ist was schief gegangen, nochmal probieren.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.