Skip to content

Task expiration - #193

Merged
maelorn merged 4 commits into
0.9.xfrom
task_expiry
Feb 8, 2018
Merged

Task expiration#193
maelorn merged 4 commits into
0.9.xfrom
task_expiry

Conversation

@maelorn

@maelorn maelorn commented Jan 11, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@sylvinus
sylvinus changed the base branch from master to 0.9.x January 11, 2018 17:32
@sylvinus sylvinus changed the title Task expirartion Task expiration Jan 12, 2018

@sylvinus sylvinus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread mrq/job.py Outdated
task_def = self.get_task_config()

self.timeout = task_def.get("timeout", cfg["default_job_timeout"])
self.default_ttl = task_def.get("default_ttl")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also have a cfg["default_job_ttl"] ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, It can be useful to easily clean old jobs and better for consistency.

ismael added 3 commits January 15, 2018 09:15
* 0.9.x:
  update known queues when requeuing jobs
  fix makefile
  add minified js
@maelorn
maelorn merged commit 5ee1335 into 0.9.x Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants