Fix encoding error (python 3) - #141
Merged
Merged
Conversation
Contributor
|
Yay! :) |
|
This breaks using Python2, we had problems with that key for example: isinstance(key, str) means something different in Python3 and Python2, being unicode in Python 3 but bytes in Python2. maybe a check for |
Contributor
Author
|
Indeed the |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BTW we now use MRQ successfully in production with python 3.5.2 at Serenytics :)
Thanks again @sylvinus for sharing this lib!