Locked jobs - #137
Merged
Merged
Conversation
Contributor
|
sylvinus
reviewed
Dec 7, 2016
|
|
||
| """ Requeue jobs that were marked as status=interrupt when a worker got a SIGTERM. """ | ||
|
|
||
| max_concurrency = 1 |
Contributor
There was a problem hiding this comment.
"maxconcurrency" serait plus facile à grepper ?
Contributor
Author
There was a problem hiding this comment.
c'est par respect de la sémantique existante, avec par exemple le Job.max_retries
| 'to dequeue them in command-line order.') | ||
|
|
||
| parser.add_argument( | ||
| '--lock_timeout', |
| default=1., | ||
| type=float, | ||
| action='store', | ||
| help='Max seconds to wait for a lock before changing the job status to expired.') |
| pipeline = context.connections.redis.pipeline() | ||
| pipeline.incr(self.redis_concurrency_key) | ||
| pipeline.expireat(self.redis_concurrency_key, int(time.time()) + self.timeout) | ||
| current = pipeline.execute()[0] |
Contributor
There was a problem hiding this comment.
this is not safe enough - with maxconcurrency=2, if a worker dies here, the count will stay at a minimum at 1, and if there are still tasks happening, the key will never expire.
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mrq.task.Task, to lock a job execution by his task path.mrq.basetasks.cleaning.[RequeueInterruptedJobs, RequeueRetryJobs, RequeueStartedJobs, RequeueRedisStartedJobs, RequeueLostJobs, MigrateKnownQueues, CleanKnownQueues, ]as locked jobs.