Store k-v from config file in 'from_file' dict - #123
Closed
ecebuzz wants to merge 1 commit into
Closed
Conversation
This prevent key value pairsparsed from config file from leaking into 'default_config'. Those key value pairs will eventually get merged into 'merged_config'.
Contributor
Author
|
Sorry, my change failed the unit test. Perhaps my understanding is not correct. I found that 'from_file' seems not being used during the configuration merging stage. So I guess that your initial intention might be setting 'from_dict' when parsing the config file. |
Contributor
|
Hm, thanks again for noticing this! This area of the code is indeed very confusing. Let me add a few tests! |
Contributor
|
There you go. Thanks again, feel free to open other issues if you see more bugs :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents key value pairs parsed from config file from leaking into 'default_config'.
Those key value pairs stored in 'from_file' will eventually be merged into 'merged_config'.
And it seems that the merging logic will have the settings from the configuration file overwrite the same settings specified by the environment variable and the arguments.