Feature/trello power up - #1
Merged
Merged
Conversation
stefan-as
force-pushed
the
feature/trello_power_up
branch
from
January 10, 2025 15:01
8965fdb to
1f58163
Compare
alexej-rotar
suggested changes
Jan 13, 2025
alexej-rotar
left a comment
alexej-rotar
left a comment
Contributor
There was a problem hiding this comment.
typo und paar fragen. sonst siehts gut aus
| <form id="trektorSettings"> | ||
| <p>Copy your personal API Token from <a href="https://track.toggl.com/profile" target="_blank">Toggl Profile page</a> and paste into field below.</p> | ||
| <label for="togglToken">Toggl Token</label> | ||
| <input type="password" id="togglToken" /> |
Contributor
There was a problem hiding this comment.
muss das wirklich password sein? das token ist ja auch beim Kopieren in Plaintext zu sehen. Ist vielleicht hilfreich zu sehen, dass man das Richtige gepastet hat?
| const response = await fetch(url, { | ||
| method, | ||
| headers: { | ||
| Authorization: `Basic ${btoa(`${this.#token}:api_token`)}`, |
| async #getProjectId(workspaceId, projectName) { | ||
| const allProjects = await this.#gateway.getProjects(workspaceId); | ||
| const projects = allProjects.filter((project) => | ||
| project.name.endsWith(`(${projectName})`), |
Contributor
There was a problem hiding this comment.
warum endsWith und nicht exakt gleich?
| return t | ||
| .get("card", "shared", "tracking") | ||
| .then((tracking) => | ||
| tracking == null |
Contributor
There was a problem hiding this comment.
Suggested change
| tracking == null | |
| tracking === null |
alexej-rotar
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.