Skip to content

Commit c3b283e

Browse files
committed
Split cancel & abort TTLs
1 parent 8a75885 commit c3b283e

2 files changed

Lines changed: 16 additions & 7 deletions

File tree

mrq/config.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,14 +156,21 @@ def add_parser_args(parser, config_type):
156156
default=7 * 24 * 3600,
157157
action='store',
158158
type=int,
159-
help='Seconds the results are kept in MongoDB when status in (success)')
159+
help='Seconds the results are kept in MongoDB when status is success')
160160

161161
parser.add_argument(
162-
'--default_job_aborted_or_canceled_ttl',
162+
'--default_job_abort_ttl',
163163
default=24 * 3600,
164164
action='store',
165165
type=int,
166-
help='Seconds the tasks are kept in MongoDB when status in (cancel, abort)')
166+
help='Seconds the tasks are kept in MongoDB when status is abort')
167+
168+
parser.add_argument(
169+
'--default_job_cancel_ttl',
170+
default=24 * 3600,
171+
action='store',
172+
type=int,
173+
help='Seconds the tasks are kept in MongoDB when status is cancel')
167174

168175
parser.add_argument(
169176
'--default_job_timeout',

mrq/job.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ class Job(object):
2323

2424
timeout = None
2525
result_ttl = None
26-
aborted_or_canceled_ttl = None
26+
abort_ttl = None
27+
cancel_ttl = None
2728
max_retries = None
2829
retry_delay = None
2930

@@ -128,7 +129,8 @@ def set_data(self, data):
128129

129130
self.timeout = task_def.get("timeout", cfg["default_job_timeout"])
130131
self.result_ttl = task_def.get("result_ttl", cfg["default_job_result_ttl"])
131-
self.aborted_or_canceled_ttl = task_def.get("aborted_or_canceled_ttl", cfg["default_job_aborted_or_canceled_ttl"])
132+
self.abort_ttl = task_def.get("abort_ttl", cfg["default_job_abort_ttl"])
133+
self.cancel_ttl = task_def.get("cancel_ttl", cfg["default_job_cancel_ttl"])
132134
self.max_retries = task_def.get("max_retries", cfg["default_job_max_retries"])
133135
self.retry_delay = task_def.get("retry_delay", cfg["default_job_retry_delay"])
134136

@@ -342,15 +344,15 @@ def save_success(self, result=None):
342344

343345
def save_cancel(self):
344346

345-
dateexpires = datetime.datetime.utcnow() + datetime.timedelta(seconds=self.aborted_or_canceled_ttl)
347+
dateexpires = datetime.datetime.utcnow() + datetime.timedelta(seconds=self.cancel_ttl)
346348
updates = {
347349
"dateexpires": dateexpires
348350
}
349351

350352
self._save_status("cancel", updates)
351353

352354
def save_abort(self):
353-
dateexpires = datetime.datetime.utcnow() + datetime.timedelta(seconds=self.aborted_or_canceled_ttl)
355+
dateexpires = datetime.datetime.utcnow() + datetime.timedelta(seconds=self.abort_ttl)
354356
updates = {
355357
"dateexpires": dateexpires
356358
}

0 commit comments

Comments
 (0)