Save abort traceback (#149)

Fixes #148 
* when aborting, save exception

* add AbortOnFailed test task

* test that traceback is saved when aborting

Author: mehdigmira

mrq/job.py

@@ -433,7 +433,7 @@ def save_abort(self):
             "dateexpires": dateexpires
         }
 
-        self._save_status("abort", updates)
+        self._save_status("abort", updates, exception=True)
 
     def _save_status(self, status, updates=None, exception=False, w=None, j=None):
 

tests/tasks/general.py

@@ -147,13 +147,31 @@ def run(self, params):
         raise Exception(params.get("message", ""))
 
 
+class InAbortException(BaseException):
+    pass
+
+
 class Abort(Task):
 
     def run(self, params):
 
         abort_current_job()
 
 
+class AbortOnFailed(Task):
+    def run(self, params):
+
+        log.info("Will abort this task")
+
+        connections.mongodb_jobs.tests_inserts.insert(params)
+        try:
+            raise InAbortException
+        except InAbortException:
+            abort_current_job()
+
+        raise Exception("Should not be reached")
+
+
 class ReturnParams(Task):
 
     def run(self, params):

tests/test_abort.py

@@ -1,8 +1,8 @@
-from mrq.job import Job
-from mrq.queue import Queue
 from datetime import datetime
 from datetime import timedelta
 
+from mrq.queue import Queue
+
 
 def test_abort(worker):
 
@@ -19,3 +19,22 @@ def test_abort(worker):
     assert job["status"] == "abort"
     assert job.get("dateexpires") is not None
     assert job["dateexpires"] < datetime.utcnow() + timedelta(hours=24)
+
+
+def test_abort_traceback_history(worker):
+
+    worker.start(flags="--config tests/fixtures/config-tracebackhistory.py")
+
+    worker.send_task("tests.tasks.general.Abort", {"a": 41}, block=True, accept_statuses=["abort"])
+
+    job = worker.mongodb_jobs.mrq_jobs.find()[0]
+
+    assert len(job["traceback_history"]) == 1
+    assert not job["traceback_history"][0].get("original_traceback")
+
+    worker.send_task("tests.tasks.general.AbortOnFailed", {"a": 41}, block=True, accept_statuses=["abort"])
+
+    job = worker.mongodb_jobs.mrq_jobs.find({"path": "tests.tasks.general.AbortOnFailed"})[0]
+
+    assert len(job["traceback_history"]) == 1
+    assert "InAbortException" in job["traceback_history"][0].get("original_traceback")